Just one minor comment to start with: > --- linux-2.6.orig/drivers/spi/Kconfig > +++ linux-2.6/drivers/spi/Kconfig > @@ -237,5 +237,11 @@ > > # (slave support would go here) > > +config SPI_SLAVE_JBT6K74 > + tristate "tpo JP6K74 LCM ASIC control interface" > + depends on SPI_MASTER && SYSFS > + help > + Driver for the tpo JP6K74-AS LCM SPI control interface. > + > endmenu # "SPI support" >
It's not a slave-side driver though ... it's a master-side driver, depending on SPI_MASTER, and making bus master calls like spi_write(). I think the Kconfig could stand to be more informative too. "LCM" is as cryptic as "tpo", there's no clue about what is controlled (SPI?), and the symbols are internally inconsistent: "JBT" != "JP", etc So after I get you any technical comments, I'll want a new patch with Kconfig and Makefile updates going in the proper place. (I'm not sure I'll have many technical comments.) - Dave ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
