Eric Miao wrote: > Let me clarify: > > Yes, I apologize I break the potential rules here for two reasons: > > 1. I was not aware of the existence of spi-devel-general mailinglist > at that time (I know this now :) > > 2. This patch is one of the series of patches refactoring PXA/ARM SSP > code, and the other patches are tightly PXA/ARM related, and David > reviewed part of the patch if not all.
I guess change is the price of progress. > And indeed yes, I will fire another patch correcting the doc, maybe > after another round of SSP code clean-up. Thanks. > Any other concerns/issues about the driver, please make me CC'ed, so > I'll try fix them if Stephen isn't available. The only outstanding issue that I am aware of is a minor problem with the sequence of setting chip select that was discussed on spi-devel-general this week. Stephen has not chimed in on that issue, so I will submit a patch for that myself, either tomorrow or early next week. I will do this patch so that it won't break a heavily modified version of pxa2xx_spi.c that I am working on, which deals with chained transfers using DMA descriptors (don't expect to ever see it submitted for inclusion in the kernel, but I am trying to stay in sync, anyway). I have examined the patches you submitted, so far, and I think they do not interfere with my version. Someday I will be able to test, but I work from the distribution provided with the Gumstix computers, and they are currently at 2.6.21 (and I am still at 2.6.20), so it may be a year or more before I see 2.6.25. -- Ned Forrester [EMAIL PROTECTED] Oceanographic Systems Lab 508-289-2226 Applied Ocean Physics and Engineering Dept. Woods Hole Oceanographic Institution Woods Hole, MA 02543, USA http://www.whoi.edu/sbl/liteSite.do?litesiteid=7212 http://www.whoi.edu/hpb/Site.do?id=1532 http://www.whoi.edu/page.do?pid=10079 ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
