The title is "spi_s3c24xx must initialize num_chipselect"
On Tue, 15 Apr 2008 10:56:43 -0700 David Brownell <[EMAIL PROTECTED]> wrote: > From: Ben Dooks <[EMAIL PROTECTED]> > > The s3c24xx_spi_txrx() function should initialise the completion > each time before using it, otherwise we end up with the possibility > of returning success before the interrupt handler has processed > all the data. > > Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> > Signed-off-by: David Brownell <[EMAIL PROTECTED]> > --- > drivers/spi/spi_s3c24xx.c | 3 +++ > 1 file changed, 3 insertions(+) > > --- at91.orig/drivers/spi/spi_s3c24xx.c 2008-04-15 10:30:32.000000000 > -0700 > +++ at91/drivers/spi/spi_s3c24xx.c 2008-04-15 10:30:35.000000000 -0700 > @@ -192,8 +192,11 @@ static int s3c24xx_spi_txrx(struct spi_d > hw->len = t->len; > hw->count = 0; > > + init_completion(&hw->done); > + > /* send the first byte */ > writeb(hw_txbyte(hw, 0), hw->regs + S3C2410_SPTDAT); > + > wait_for_completion(&hw->done); > > return hw->count; But you (re)sent a copy of "spi_s3c24xx driver must init completion" ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
