On Apr 23, 2008, at 3:19 PM, Roel Kluin wrote:
> mpc83xx_spi->irq is unsigned, so the test fails
>
> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>

you should copy the linux-spi list on such patches.

- k

>
> ---
> diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
> index be15a62..033fd51 100644
> --- a/drivers/spi/spi_mpc83xx.c
> +++ b/drivers/spi/spi_mpc83xx.c
> @@ -454,12 +454,12 @@ static int __init mpc83xx_spi_probe(struct  
> platform_device *dev)
>               goto put_master;
>       }
>
> -     mpc83xx_spi->irq = platform_get_irq(dev, 0);
> -
> -     if (mpc83xx_spi->irq < 0) {
> -             ret = -ENXIO;
> +     ret = platform_get_irq(dev, 0);
> +     if (ret < 0)
>               goto unmap_io;
> -     }
> +
> +     mpc83xx_spi->irq = ret;
> +     ret = 0;
>
>       /* Register for SPI Interrupt */
>       ret = request_irq(mpc83xx_spi->irq, mpc83xx_spi_irq,


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Reply via email to