On Monday 28 April 2008, Jonathan Cameron wrote:
> 
> from Jonathan Cameron <[EMAIL PROTECTED]>
> 
> Initial support for ST Microelectronics LISS3L02DQ accelerometer via SPI

Extra "S" there I think.  :)


> Signed-off-by: Jonathan Cameron <[EMAIL PROTECTED]>
> 
> ---
> 
> This is a corrected version of the patch I posted the other day.  
> All comments / feedback welcomed. Would it be preferable to submit this
> as two patches, the first containing the basic functionality for directly
> accessing the device and second patching against that to add ring buffer /
> interrupt support?

One patch is fine, I think.


>  drivers/spi/Kconfig           |   14
>  drivers/spi/LIS3L02DQ.c       |  774 ++++++++++++++++++++++++++++++++
>  drivers/spi/Makefile          |    1
>  include/linux/spi/LIS3L02DQ.h |  168 ++++++
>  4 files changed, 957 insertions(+)

First technical feedback:  names in *lower case* please!  Hold
off on a new patch until I look at the code a bit.

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Reply via email to