On Fri, May 23, 2008 at 11:31 AM, David Brownell <[EMAIL PROTECTED]> wrote: > On Wednesday 21 May 2008, Andrew Morton wrote: >> On Wed, 21 May 2008 17:04:56 -0700 David Brownell <[EMAIL PROTECTED]> wrote: >> >> > From: Grant Likely <[EMAIL PROTECTED]> >> > ... >> > - proxy->modalias = chip->modalias; >> > + strncpy(proxy->modalias, chip->modalias, KOBJ_NAME_LEN); >> > ... >> >> a) strncpy() doesn't null-terminate the dest if it overran. strlcpy() does. >> >> b) Given the uncertainly over the state of existing code, perhaps we >> should have an explicit check for overflows here, with a WARN_ON()? >> >> c) I think it's better to use sizeof() in the strlcpy() rather than >> duplicating the array size - it's a little more robust in the face >> of future changes and it is more obviously-correct (don't need to go >> elsewhere to check the size of the destination). > > Good points. I usually try to use sizeof() myself, for exactly > that reason. Updated version (below) uses strlcpy, sizeof, WARN_ON.
Woo! I get wrapped up in other code for a few days and someone else does my work for me. :-) Dave, thanks for updating the patch. I truly appreciate it. New version looks good to me. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
