On Tuesday 02 December 2008, Baruch Siach wrote:
> Packet data read from the RX buffer the when the RSV is at the end of the RX
> buffer does not warp around. This causes packet loss, as the actual data is
> never read. Fix this by calculating the right packet data location.
>
> Thanks to Shachar Shemesh for suggesting the fix.
>
> Signed-off-by: Baruch Siach <[EMAIL PROTECTED]>
>
> ---
Seems plausible to me, but network patches should be submitted
to the netdev list. :)
I CC'd them on this reply ... if nobody gives any feedback, I'll
suggest you resubmit there on Friday.
- Dave
p.s. Just for info ... what kind of Linux system are you using
this driver on?
>
> --- drivers/net/enc28j60.c-git 2008-12-02 09:08:24.000000000 +0200
> +++ drivers/net/enc28j60.c 2008-12-02 09:38:33.000000000 +0200
> @@ -568,6 +568,17 @@ static u16 erxrdpt_workaround(u16 next_p
> return erxrdpt;
> }
>
> +/*
> + * Calculate wrap around when reading beyond the end of the RX buffer
> + */
> +static u16 rx_packet_start(u16 ptr)
> +{
> + if (ptr + RSV_SIZE > RXEND_INIT)
> + return (ptr + RSV_SIZE) - RXEND_INIT - 1;
> + else
> + return ptr + RSV_SIZE;
> +}
> +
> static void nolock_rxfifo_init(struct enc28j60_net *priv, u16 start, u16 end)
> {
> u16 erxrdpt;
> @@ -938,8 +949,9 @@ static void enc28j60_hw_rx(struct net_de
> skb->dev = ndev;
> skb_reserve(skb, NET_IP_ALIGN);
> /* copy the packet from the receive buffer */
> - enc28j60_mem_read(priv, priv->next_pk_ptr + sizeof(rsv),
> - len, skb_put(skb, len));
> + enc28j60_mem_read(priv,
> + rx_packet_start(priv->next_pk_ptr),
> + len, skb_put(skb, len));
> if (netif_msg_pktdata(priv))
> dump_packet(__func__, skb->len, skb->data);
> skb->protocol = eth_type_trans(skb, ndev);
>
> --
> ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - [EMAIL PROTECTED] - tel: +972.2.679.5364, http://www.tkos.co.il -
>
>
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
