On Thu, 5 Feb 2009 18:07:33 +0800 Bryan Wu <[email protected]> wrote:
> 1. Rewrite of the non-dma data transfer functions to use only ONE > mode of TIMOD (TIMOD=0x1). With TIMOD=0, it was not possible to set > the TX bit pattern. So the TDBR = 0xFFFF inside the read calls won't > work. > > 2. Clear SPI_RDBR before reading and before duplex transfer. Otherwise > the garbage data in RDBR will get read. Since mmc_spi uses a lot of > duplex transfers, this is the main cause of mmc_spi failure. > > 3. Poll RXS for transfer completion. Polling SPIF or TXS cannot > guarantee transfer completion. This may interrupt a transfer before > it is finished. Also this may leave garbage data in buffer and > affect next transfer. > > [Yi Li <[email protected]>: add a field "u16 idle_tx_val" in "struct > bfin5xx_spi_chip" to specify the value to transmit if no TX value > is supplied.] again, driver-core has destroyed your patch. There was no _need_ to take the unusual and undesirable step of modifying SPI via an unrelated tree. ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
