On Sun, May 31, 2009 at 09:27:56PM +0200, Linus Walleij wrote: > 2009/5/31 Baruch Siach <[email protected]>: > > >> > + r = platform_get_resource(dev, IORESOURCE_MEM, 0); > >> > + if (r == NULL) { > >> > + ret = -ENODEV; > >> > >> -ENOENT > > > > A quick search in the drivers tree showed no -ENOENT in this situation. Of > > the > > 10 first results of grep -ENODEV is the most popular as follows: > [The other: 3x -EINVAL one -ENXIO] > > Wowsers! And I felt -ENOENT was so intuitive, well if I'm going against > common practice, no good. So let's ask the maintainer of the platform bus > what shall be returned in this situation: > > Greg (or some other wise person from linux-kernel) what would you return if > platform_get_resource() returns NULL for an expected resource?
I really have no idea, sorry. Pick something :) thanks, greg k-h ------------------------------------------------------------------------------ OpenSolaris 2009.06 is a cutting edge operating system for enterprises looking to deploy the next generation of Solaris that includes the latest innovations from Sun and the OpenSource community. Download a copy and enjoy capabilities such as Networking, Storage and Virtualization. Go to: http://p.sf.net/sfu/opensolaris-get _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
