* David Brownell <[email protected]> [090703 03:22]: > On Tuesday 23 June 2009, Hemanth V wrote: > > This patch adds support for McSPI slave and FIFO. DMA and FIFO > > could be enabled together for better throughput. > > > > This has a dependency on patch > > [RESEND][PATCH 1/2] McSPI Slave and DMA,FIFO support > > ... in this case I'd think they would better be part of > a single patch. > > However, anything related to SPI slave support should > be separated entirely from FIFO support. > > Ditto anything adding more SPI_DEBUG support. > > Oh, and use the BIT(n) syntax not (1 << n) in the new > constants you define... the patch making this driver > use that style finally went upstream.
I agree with Dave's comments. Maybe repost one more time, then I'd actually prefer these get merged via the SPI list once everybody's happy. Tony ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
