On Thu, 27 Aug 2009 18:47:42 -0700 David Brownell <[email protected]> wrote:
> Subject: [PATCH] Freescale STMP spi driver, revised > From: dmitry pervushin <[email protected]> > Date: Wed, 03 Jun 2009 20:15:46 +0400 > > Add SPI driver for Freescale STMP 3xxx-based boards > > [[email protected]: cleanup sequence, spi_unregister_master] > Does "freescale" have a maintainer? Me no understand it. > +#define busy_wait(cond) > \ > + ({ \ > + unsigned long end_jiffies = jiffies + STMP_SPI_TIMEOUT; \ > + bool succeeded = false; \ > + do { \ > + if (cond) { \ > + succeeded = true; \ > + break; \ > + } \ > + cpu_relax(); \ > + } while (time_before(end_jiffies, jiffies)); \ > + succeeded; \ > + }) Oh dear. > +/** > + * stmp_spi_init_hw > + * Initialize the SSP port > + */ The /** token indicates that the comment is in kerneldoc form. But this comment lacks all the stuff one would expect to see in a kerneldoc comment. > > ... > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
