On Wed, Dec 09, 2009 at 08:08:19AM -0700, Grant Likely wrote:
> (resend because I forgot to cc the mailing list)
>
> 2009/12/9 Uwe Kleine-König <[email protected]>:
> > Hello Grant,
> >
> > On Tue, Dec 08, 2009 at 05:38:57PM -0700, Grant Likely wrote:
> >> > diff -puN
> >> > drivers/spi/spi_imx.c~spi-imx-correct-check-for-platform_get_irq-failing
> >> > drivers/spi/spi_imx.c
> >> > ---
> >> > a/drivers/spi/spi_imx.c~spi-imx-correct-check-for-platform_get_irq-failing
> >> > +++ a/drivers/spi/spi_imx.c
> >> > @@ -554,7 +554,7 @@ static int __init spi_imx_probe(struct p
> >> > }
> >> >
> >> > spi_imx->irq = platform_get_irq(pdev, 0);
> >> > - if (!spi_imx->irq) {
> >> > + if (spi_imx->irq < 0) {
> >>
> >> This changes the old behaviour. Is that what you intended? '<= 0'
> >> perhaps?
> > Yes, the old check was wrong. What if the irq to use is 0? I thought
> > the commit log to be understandable. platform_get_irq returns -ENXIO on
> > error and an irq number on success. So 0 has to be interpreted as valid
> > irq, not an error.
>
> 0 is not a valid IRQ
Hmm, on my x86 I have:
$ grep '\<0:' /proc/interrupts
0: 24330 IO-APIC-edge timer
arm/davinci starts at 0, too. As does arm/ns9xxx. arm/pxa seems to
start at 1. realview starts at 1, too. So four out of five make are
wrong? Seems like a big area for cleanup.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
