On Wed, Dec 16, 2009 at 05:10:08PM +0100, Uwe Kleine-König wrote: > platform_get_irq returns -ENXIO on failure, so !irq was probably > always true. Better use (int)irq <= 0. Note that a return value of > zero is still handled as error even though this could mean irq0. > > This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that > changed the return value of platform_get_irq from 0 to -ENXIO on error. > > Signed-off-by: Uwe Kleine-König <[email protected]> > Cc: David Vrabel <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: David Brownell <[email protected]> > Cc: Grant Likely <[email protected]> > Cc: Kumar Gala <[email protected]> > Cc: Anton Vorontsov <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: [email protected] > --- > drivers/spi/spi_mpc8xxx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c > index e9390d7..b13501a 100644 > --- a/drivers/spi/spi_mpc8xxx.c > +++ b/drivers/spi/spi_mpc8xxx.c > @@ -1339,7 +1339,7 @@ static int __devinit plat_mpc8xxx_spi_probe(struct > platform_device *pdev) > return -EINVAL; > > irq = platform_get_irq(pdev, 0); > - if (!irq) > + if ((int)irq <= 0)
I tend to think that it's really hopeless to fix the platform_get_irq() in its current form, so can you get rid of this ugly cast and just make the irq signed? And I'll be fine with it. :-( -- Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2 ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
