Hi Pietrek,
On Fri, Jan 29, 2010 at 02:48:29PM +0100, Pietrek, Markus wrote:
[snip]
> + else if (!strcmp(opt, "cs"))
> + info->mode |= SPI_CS_HIGH;
The name of this option should be "cs_high" in my opinion.
> + else if (!strcmp(opt, "lsb"))
> + info->mode |= SPI_LSB_FIRST;
> + else if (!strcmp(opt, "3wire"))
> + info->mode |= SPI_3WIRE;
> + else if (!strcmp(opt, "loop"))
> + info->mode |= SPI_LOOP;
> + else if (!strcmp(opt, "no_cs"))
> + info->mode |= SPI_NO_CS;
> + else if (!strcmp(opt, "ready"))
> + info->mode |= SPI_READY;
> + else {
> + pr_err(DRIVER_NAME ": Don't know
> value %s\n", opt);
> + kfree(info);
> + return -1;
> + }
For the sake of future compatibility I think we should ignore unknown options,
and print a message along the lines of "Unknown option %s, ignoring".
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.2.679.5364, http://www.tkos.co.il -
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
