On Sat, Aug 21, 2010 at 1:17 AM, Mark Brown
<[email protected]> wrote:
> The S3C64xx SPI driver requires the machine to call s3c64xx_spi_set_info()
> to select a few options, including the clock to use for the SPI controller.
> If this is not done then a NULL will be passed as the clock name for
> clk_get(), causing an obscure crash. Guard against this and other missing
> configuration by validating that the clock name has been filled in in
> the platform data that ets passed in.
The movement of sci assignment and check doesn't make any
difference because
we already check for presence of platform_data and DMA-Tx,Rx and
IO base is
set irrespective of calling s3c64xx_spi_set_info()
Also, I think !sci->num_cs might be an even better check because
the samsung clock
api might be changed (IIRC Ben was already working it out) to make
it redundant
to pass clock name strings to clk_get. If that is the case, we might end up
adding another foolproof check like !sci->num_cs
what do you guys think?
regards
------------------------------------------------------------------------------
This SF.net email is sponsored by
Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
