--- On Tue, 8/31/10, Soulard, MathieuX <[email protected]> wrote:
> > ... Actually some SPI controller drivers handle a > specific spi_device.controller_data as input in their setup > operation, and the controller driver I'm testing uses this > field in its setup operation, if provided. > > The driver spidev.c handles many commands through ioctl but > it does not provide a way to setup a specific > controller_data. And it shouldn't, any more than platform_data. > > I would like to get your opinion about this field usage > from the protocol driver, since I'm not sure to understand > the way this field has be used: is it really supposed to be > used by the protocol driver to deliver some controller's > specific setup, or, is it a field we should ignore from the > protocol driver perspective as Ignore it. It's a sibling to the platform_data field, and should be set up with that. Neither one should be assigned or understood by protocol drivers. Historically, controller_data was used ISTR to cope with tuning that the PXA SPI controller required (DMA etc). Most controllers should have no need for it. it is supposed to be only > managed by the controller driver if it needs it ? > > Then, I would like to get your opinion about the attached > patch I'm using to get an access to controller_data from the > user space. I wrote this patch since the SPI driver I'm > testing handles a specific spi_device.controller_data in its > setup operation. It allows me to provide it from user space > through spidev.c. > > > Thanks > Regards > > Mathieu > --------------------------------------------------------------------- > Intel Corporation SAS (French simplified joint stock > company) > Registered headquarters: "Les Montalets"- 2, rue de Paris, > > 92196 Meudon Cedex, France > Registration Number: 302 456 199 R.C.S. NANTERRE > Capital: 4,572,000 Euros > > This e-mail and any attachments may contain confidential > material for > the sole use of the intended recipient(s). Any review or > distribution > by others is strictly prohibited. If you are not the > intended > recipient, please contact the sender and delete all > copies. > > -----Inline Attachment Follows----- > > ------------------------------------------------------------------------------ > This SF.net Dev2Dev email is sponsored by: > > Show off your parallel programming skills. > Enter the Intel(R) Threading Challenge 2010. > http://p.sf.net/sfu/intel-thread-sfd > -----Inline Attachment Follows----- > > _______________________________________________ > spi-devel-general mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/spi-devel-general > ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
