On Wed, Sep 01, 2010 at 09:24:12AM -0600, Grant Likely wrote:
> On Mon, Aug 30, 2010 at 11:54:17PM +0200, David Lamparter wrote:
> > introduced by 49dce689ad4ef0fd1f970ef762168e4bd46f69a3 and bad-fixed by
> > 350d0076c5763ca2b88ca05e3889bfa7c1905f21, spi_unregister_master would
> > previously device_unregister all of the spi master's siblings (instead
> > of its children). hilarity ensues.
>
> Obviously correct. Applied, and I'll push it out after some testing.
Thanks!
> BTW, you should be friendly to reviewers when quoting sha1 commit
> ids. You should also quote the patch title so that readers don't
> need to context-switch to git or the web to figure out what the
> patches actually are. This is how I fixed it up in the commit:
>
> introduced by 49dce689 ("spi doesn't need class_device") and bad-fixed
> by 350d0076 ("spi: fix double-free on spi_unregister_master"),
> spi_unregister_master would previously device_unregister all of the spi
> master's siblings (instead of its children). hilarity ensues.
Ah. I oriented on 350d0076's commit message ("spi: fix double-free on
spi_unregister_master") which did strike me as weird, but I didn't
think. Will remember to do better in the future.
-David
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
