On Fri, Sep 03, 2010 at 10:36:46AM +0900, Jassi Brar wrote:
> Instead of, wrongly, reusing the 'val' variable, use a dedicated
> one for reading the status register.
>
> Signed-off-by: Jassi Brar <[email protected]>
Applied to spi-merge, thanks.
g.
> ---
> drivers/spi/spi_s3c64xx.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
> index 12e7915..39816bb 100644
> --- a/drivers/spi/spi_s3c64xx.c
> +++ b/drivers/spi/spi_s3c64xx.c
> @@ -326,10 +326,11 @@ static int wait_for_xfer(struct s3c64xx_spi_driver_data
> *sdd,
> val = msecs_to_jiffies(ms) + 10;
> val = wait_for_completion_timeout(&sdd->xfer_completion, val);
> } else {
> + u32 status;
> val = msecs_to_loops(ms);
> do {
> - val = readl(regs + S3C64XX_SPI_STATUS);
> - } while (RX_FIFO_LVL(val, sci) < xfer->len && --val);
> + status = readl(regs + S3C64XX_SPI_STATUS);
> + } while (RX_FIFO_LVL(status, sci) < xfer->len && --val);
> }
>
> if (!val)
> --
> 1.6.2.5
>
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
