On Thu, Sep 16, 2010 at 09:05:03AM +0200, christophe leroy wrote: > This patch applies to 2.6.34.7 and 2.6.35.4 > It fixes an issue during the probe for CPM1 with definition of parameter ram > from DTS > > Signed-off-by: christophe leroy <[email protected]>
I'm sorry, I don't understand the fix from the given description. What is the problem, and why is cpm_muram_alloc_fixed() the wrong thing to call on CPM1? Does CPM2 still need it? g. > > diff -urN b/drivers/spi/spi_mpc8xxx.c c/drivers/spi/spi_mpc8xxx.c > --- b/drivers/spi/spi_mpc8xxx.c 2010-09-08 16:43:50.000000000 +0200 > +++ c/drivers/spi/spi_mpc8xxx.c 2010-09-08 16:44:03.000000000 +0200 > @@ -822,7 +822,7 @@ > if (!iprop || size != sizeof(*iprop) * 4) > return -ENOMEM; > > - spi_base_ofs = cpm_muram_alloc_fixed(iprop[2], 2); > + spi_base_ofs = iprop[2]; > if (IS_ERR_VALUE(spi_base_ofs)) > return -ENOMEM; > > @@ -844,7 +844,6 @@ > return spi_base_ofs; > } > > - cpm_muram_free(spi_base_ofs); > return pram_ofs; > } ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
