On Mon, Oct 18, 2010 at 02:14:28AM -0400, Mike Frysinger wrote: > On Mon, Oct 18, 2010 at 02:12, Grant Likely wrote: > > On Sun, Oct 17, 2010 at 06:59:41PM -0400, Mike Frysinger wrote: > >> From: Michael Hennerich <[email protected]> > >> > >> Some systems using this bus sometimes have very basic devices on them > >> such as regulators. So we need to be loaded even earlier in case the > >> devices are used before userspace is loaded. Therefore register in > >> subsys_initcall(). > > > > This shouldn't have anything to do with userspace since regardless of > > the initcall, all of this setup should be complete before userspace > > starts. Rather I expect it has to do with an earlier initcall wanting > > to have the spi bus up earlier than module_initcall. The description > > of this patch seems wrong. > > probably. it doesnt make the change wrong though. many spi/i2c > busses do the same thing.
Not saying it does. Just asking for the commit log to be changed. > > > On that note, this is something that needs to be revisited. Needing > > to play these kind of games highlights a failure of the device model, > > or the way that it is being used. (The patch is okay; but it does > > highlight some ugliness in the current kernel) > > i agree, but i'm not about to embark on fixing these fundamental issues. Indeed. I'm certainly not asking you to. Just thinking out loud. :-) g. ------------------------------------------------------------------------------ Download new Adobe(R) Flash(R) Builder(TM) 4 The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly Flex(R) Builder(TM)) enable the development of rich applications that run across multiple browsers and platforms. Download your free trials today! http://p.sf.net/sfu/adobe-dev2dev _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
