On Mon, Oct 18, 2010 at 02:20, Grant Likely wrote:
> On Mon, Oct 18, 2010 at 02:10:17AM -0400, Mike Frysinger wrote:
>> On Mon, Oct 18, 2010 at 02:02, Grant Likely wrote:
>> > On Sun, Oct 17, 2010 at 06:59:24PM -0400, Mike Frysinger wrote:
>> >> -struct driver_data {
>> >> +struct master_data {
>> >
>> > Or better yet, to protect against global collisions, bfin5xx_master
>> > perhaps?
>>
>> i'd rather not. there is too much "bfin5xx" stuff already which
>> shouldnt exist. what collision could there possibly be ?
>
> For driver code, anything at the file scope has a potential conflict
> with the global scope. If any header in include/linux were to define
> a "master_data" or a "slave_data" structure, (those are pretty generic
> names, it is well within the realm of possibilities) then it would
> conflict.
i dont think generic names like that would be allowed in global space
for this exact reason. ive already made sure all the data/function
symbols that are visible from a linkage stand point are properly
namespaced because unlike structures, those are externally visible by
tools such as kallsyms.
i'd really prefer to not have to redo all these patches considering
this one change will cascade into like 20 others. i'd be a lot more
amendable to a patch on top of all of these that namespaces the
structs.
-mike
------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
