On 10/28/2010 11:49 AM, Linus Walleij wrote: > 2010/10/26 Cyril Chemparathy <[email protected]>: > >> TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial >> port >> device. It has a built-in programmable execution engine that can be >> programmed >> to operate as almost any serial bus (I2C, SPI, EasyScale, and others). >> >> This patch adds a driver for this controller device. The driver does not >> expose a user-land interface. Protocol drivers built on top of this layer >> are >> expected to remain in-kernel. > > Why is this thing in drivers/misc? > > drivers/mfd is IMHO the apropriate place for a driver like this, and > the subdrivers should be migrated to use mfd cells and platform > drivers for the subdevices. > > All functions and abstractions you create here look suspiciously > lot like other MFD devices. > > But please, beat me up if I'm wrong!
Alan had raised the same concern earlier, and my response was: > Unlike MFDs, this device doesn't have cells with differing > functionality. Instead it has functionally identical ports that can > operate in a variety of modes. That said, does this still fit in with > other MFD drivers? If so, I don't see a problem with moving it there. I don't see a problem with moving this into MFD, but this won't be able to use any of the functionality provided by mfd-core. Thanks Cyril. ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
