Hello,
As I discussed with Russell King on the list
[email protected], there is a problem with the double
definition of 'struct flash_platform_data' that are incompatible:
in arch/arm/include/asm/mach/flash.h:
struct flash_platform_data {
const char *map_name;
const char *name;
unsigned int width;
int (*init)(void);
void (*exit)(void);
void (*set_vpp)(int on);
void (*mmcontrol)(struct mtd_info *mtd, int sync_read);
struct mtd_partition *parts;
unsigned int nr_parts;
};
in include/linux/spi/flash.h:
struct flash_platform_data {
char *name;
struct mtd_partition *parts;
unsigned int nr_parts;
char *type;
/* we'll likely add more ... use JEDEC IDs, etc */
};
Both headers are included in a number of machines or driver.
They make conflict when one has both spi flash and an other type of mtd flash
on the same machine (my case).
I suppose the ARM version has no reason not to be platform independent, but
that is an other problem.
I propose to rename SPI version of the structure as it is the younger and it is
included in a less number of files.
The patch (already sent on [email protected]) is in
attachment.
Best regards,
Alexis RODET
Le 21/11/2010 05:47, Baruch Siach a écrit :
> Hi Alexis,
>
> On Fri, Nov 19, 2010 at 06:23:09PM +0100, Alexis RODET wrote:
>>> It would, however, be nice if _someone_ out there could produce a patch
>> Here is the patch and here is the command line used for doing this:
> You need to CC the MTD maintainer and mailing list (David Woodhouse
> <[email protected]>, and [email protected] respectively), and
> maybe also the SPI subsystem maintainers (David Brownell
> <[email protected]>, Grant Likely <[email protected]>,
> [email protected]).
>
> baruch
>
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
