On Fri, Feb 04, 2011 at 19:39:12, Michael Williamson wrote: > For DMA operation, the davinci spi driver needs an event queue number. > Currently, this number is passed as a IORESOURCE_DMA. This is not > correct, as the event queue is not a DMA channel. Pass the event queue > via the platform data structure instead. > > On dm355 and dm365, move the eventq assignment for spi0 out of resources > array and into platform data. > > Signed-off-by: Michael Williamson <[email protected]>
Tested this on DM355 and DM365 EVMs. Event queue numbers show up properly in the logs and DMA transfers to on-board SPI EEPROMs happen correctly. > --- > Changes since v0: > - combined separate platform patches with driver patch to avoid > potential regression if doing a bissect. > - fixed up typo per comments. This typo doesn't seem fixed? > + * @dma_event_q: DMA event_q to use if SPI_IO_TYPE_DMA is used for any device > + * on the bus. On 2/4/2011 7:03 AM, Sergei Shtylyov wrote: >> + * @dma_event_q: DMA event_q to use if SPI_IO_TYPE_DMA is used for any >> device > > s/event_q/event queue/? Can you please re-spin with this fixed and my ack included: Acked-by: Sekhar Nori <[email protected]> With Grant's ack this should probably get merged through DaVinci tree (since it touches mach-davinci). Thanks, Sekhar ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
