On Mon, Jun 6, 2011 at 8:28 PM, Feng Tang <[email protected]> wrote: > On Tue, 7 Jun 2011 00:49:20 +0800 > Dirk Brandewie <[email protected]> wrote: > >> On 06/06/2011 09:38 AM, Grant Likely wrote: >> > On Mon, Jun 6, 2011 at 10:31 AM, Mike >> > Frysinger<[email protected]> wrote: >> >> On Mon, Jun 6, 2011 at 03:18, Grant Likely wrote: >> >>> Sort the SPI makefile and enforce the naming convention spi_*.c >> >>> for spi drivers. >> >> >> >> spi_topcliff_pch.c uses KBUILD_MODNAME with a few funcs, but >> >> perhaps those are only for /proc/ status tracking ? worth double >> >> checking ... >> > >> > I just talked with Dirk Brandewie, who has a major rewrite to the >> > topcliff spi driver. I'll let him comment on whether or not >> > changing KBUILD_MODNAME will cause any problems. >> > >> >> My changes are to the designware driver :-) I will get my patches >> re-based onto the spi-next branch and see if there any issues. > > If there is major rewrite to the dw_spi driver, please submit to this > list, as it is used by many devices out there and needs a broad review
Hmmm. Dirk, that could change things a bit. From our conversation today my understanding was that there weren't few if any users outside of your circle. If that isn't the case, then I'm going to be more cautious about merging the rewrite. Who are the people I should make sure there is feedback from when the patch gets posted? g. ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
