On 06/22/2011 07:47 PM, Feng Tang wrote:
> On Thu, 23 Jun 2011 10:00:13 +0800
> "[email protected]"<[email protected]> wrote:
>
>> From: Dirk Brandewie<[email protected]>
>>
>> The value of spi->bits_per_word is checked on function entry to be 8
>> or 16. The else clause has no meaning since it can never be reached.
>>
>> Signed-off-by: Dirk Brandewie<[email protected]>
>> ---
>> drivers/spi/spi-dw.c | 9 +++------
>> 1 files changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c
>> index 7b3f607..5ddd45f 100644
>> --- a/drivers/spi/spi-dw.c
>> +++ b/drivers/spi/spi-dw.c
>> @@ -667,17 +667,14 @@ static int spi_dw_setup(struct spi_device *spi)
>> chip->enable_dma = chip_info->enable_dma;
>> }
>>
>> - if (spi->bits_per_word<= 8) {
>> + if (spi->bits_per_word == 8) {
>> chip->n_bytes = 1;
>> chip->dma_width = 1;
>> - } else if (spi->bits_per_word<= 16) {
>> + } else if (spi->bits_per_word == 16) {
>> chip->n_bytes = 2;
>> chip->dma_width = 2;
>> - } else {
>> - /* Never take>16b case for DW SPIC */
>> - dev_err(&spi->dev, "invalid wordsize\n");
>> - return -EINVAL;
>> }
>
> These "else" case is used to ban the slave spi devices which
> try to use 32 bits per word mode. This is like to tell those
> spi devices with 32 bpw capability "we don't support 32b, pls
> change"
The function has the prerequisite code:
if (spi->bits_per_word != 8 && spi->bits_per_word != 16)
return -EINVAL;
at the begining of the function so we will never be able to reach the else
clause that is being removed.
>
>> +
>> chip->bits_per_word = spi->bits_per_word;
>>
>> chip->speed_hz = spi->max_speed_hz;
------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today.
http://p.sf.net/sfu/quest-sfdev2dev
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
