2011/8/10 Jassi Brar <jassisinghb...@gmail.com>: > On Wed, Aug 10, 2011 at 5:24 PM, Linus Walleij <linus.wall...@linaro.org> > wrote: >>> Linus W, was there anything you said wouldn't work with the scheme ? >>> Please tell now on the record. >> >> It would *work* but the current proposal is *not elegant* IMO. > > would *work* -> You could find no case that the scheme wouldn't support.
Well there is the usecase where we have a lot of devices, but it is true we don't have that kind of hardware around. > *not elegant* -> Your opinion. Let us see. Well, yeah, such is life. > Client having to specify the device it wants a channel for, is a > waste - otherwise we don't fully get rid of platform assistance for > channel selection! I think I saw you proposal define REQ(MMC,2) for example, isn't that specifying the device? >> rxc = dma_request_slave_channel(dev, "MMC-RX"); >> txc = dma_request_slave_channel(dev, "MMC-TX"); > > Absolutely "not-very-good" ! > We can do without the 'dev' argument. You still need to pass in something referring you back to the device. > How does a client request duplex channel ? Currently the duplex channels using DMA-engine switch direction of the channel at runtime with the config call.0 There is a "bidirectional" define in dmaengine.h but I haven't figured out if that is useful for slave transfers at all really. > Do you propose to implement a string parser in the core ?! Yes, the clock and regulator framework already does that. But it is only used when you cannot pass in a struct device * directly, like from device tree. >> I also recognized that you needed a priority scheme and >> a few other bits for the above, > > You didn't recognize. I told you. IIRC you suggested I should actually > sell that point! http://en.wiktionary.org/wiki/recognise 1. (transitive) To match something or someone which one currently perceives to a memory of some previous encounter with the same entity. 2. (transitive) To acknowledge the existence or legality of something.; treat as worthy of consideration or valid. The US and a number of EU countries are expected to recognise Kosovo on Monday. 3. (transitive) To acknowledge or consider as something. 4. (transitive) To realise or discover the nature of something; apprehend quality in; realise or admit that. 5. (transitive) To give an award. Sorry for spelling with "z". >> If the majority is happy with this scheme I can even >> try implementing it. > > Interesting! Only a few days ago you were seeing eternal sunshine in > filter-functions... and now you plan to implement my proposal by > replacing bit-fields with strings. Yes your argument for a better channel-lookup functionality are perfectly valid, that is what I mean when I say I recognize it. We only disagree on how to implement it. As for eternal sunshine, well, it rains here in Sweden today so the kernel is a pretty sunny place comparatively. Thanks, Linus Walleij ------------------------------------------------------------------------------ Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-dev2dev _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
