On Thu, Jan 26, 2012 at 03:48:59PM +0100, Linus Walleij wrote: > On Wed, Jan 25, 2012 at 3:02 PM, Mark Brown <broo...@sirena.org.uk> wrote:
> > It really feels like we should be pulling this into the core - lots of > > drivers use a workqueue to drive data through the system and they're all > > going to have exactly the same issue. > That reads to me like the entire message queue and "transfer pump" > mechanism from the PL022 driver should be made into generic > code. That is the key ingredient from the PL022 driver that has > allowed us to get real nice throughput on it. > And that observation is correct, but a bit of upfront code. Probably, yes - lots of drivers seem to have a workqueue of some kind that drives the actual transfers and I strongly suspect that there's a lot of generality there. I have to confess that I had just thought that "transfer pump" was an obscure bit of jargon in the changelog so it's possible it's doing something device specific but it'd seem surprising TBH. > I would make it an opt-in for SPI drivers to have a generic > message queue instead of treating messages in a one-by-one > manner. That'd certainly be nice - where things use a workqueue they do often just pass the entire request from the caller off to it in one fell swoop so that sounds compatible. ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
