On Sat, 10 Mar 2012 10:38:27 +0100, walter harms <[email protected]> wrote: > > > Am 10.03.2012 09:57, schrieb Dan Carpenter: > > We should release the lock here and enable IRQs before returning. > > > > Signed-off-by: Dan Carpenter <[email protected]> > > > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > > index 5ae1e84..ab1bdce 100644 > > --- a/drivers/spi/spi.c > > +++ b/drivers/spi/spi.c > > @@ -535,6 +535,7 @@ static void spi_pump_messages(struct kthread_work *work) > > if (ret) { > > dev_err(&master->dev, > > "failed to unprepare transfer > > hardware\n"); > > + spin_unlock_irqrestore(&master->queue_lock, > > flags); > > return; > > } > > } > > > hi Dan, > do you want to protect dev_err() by a spn_lock ?
Applied, after moving unlock above the dev_err. g. ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
