Hi SPI ML, Mark

Now I'm studying SPI core message queue by checking spi-s3c64xx.c.

And I noticed that strange code on
ad2a99af0d7242726723575efaffa1625664b384
(spi/s3c64xx: Convert to using core message queue)

current spi-s3c64xx.c :: s3c64xx_spi_transfer_one_message() is

-----------------------------------------------------------------------
static int s3c64xx_spi_transfer_one_message(struct spi_master *master,
                                            struct spi_message *msg)
{
...
        if (msg->complete)
                msg->complete(msg->context);

        spi_finalize_current_message(master);

        return 0;
}
-----------------------------------------------------------------------

But I think spi_finalize_current_message() itself will call msg->complete().
Is this double call ?
I'm not sure.

msg->complete() of spi-pl022.c was removed by
ffbbdd21329f3e15eeca6df2d4bc11c04d9d91c0
(spi: create a message queueing infrastructure)

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Reply via email to