Hi Fabio, On Tue, Mar 27, 2012 at 12:34 AM, Fabio Estevam <[email protected]> wrote: > Shubhrajyoti Datta wrote: >> Hi Fabio, >> >> On Mon, Mar 26, 2012 at 11:43 PM, Fabio Estevam >> <[email protected]> wrote: >>> Structure struct spi_imx_data is defined twice. >>> >>> Remove one of its definition. >>> >>> Signed-off-by: Fabio Estevam <[email protected]> >>> --- >>> drivers/spi/spi-imx.c | 20 +++++++++----------- >>> 1 files changed, 9 insertions(+), 11 deletions(-) >>> >>> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c >>> index 31054e3..f1f6700 100644 >>> --- a/drivers/spi/spi-imx.c >>> +++ b/drivers/spi/spi-imx.c >>> @@ -68,17 +68,6 @@ enum spi_imx_devtype { >>> IMX51_ECSPI, /* ECSPI on i.mx51 and later */ >>> }; >>> >>> -struct spi_imx_data; >>> - >>> -struct spi_imx_devtype_data { >>> - void (*intctrl)(struct spi_imx_data *, int); >>> - int (*config)(struct spi_imx_data *, struct spi_imx_config *); >>> - void (*trigger)(struct spi_imx_data *); >>> - int (*rx_available)(struct spi_imx_data *); >>> - void (*reset)(struct spi_imx_data *); >>> - enum spi_imx_devtype devtype; >>> -}; >> >> Is this change intentional > > Yes, struct spi_imx_data must be defined prior to spi_imx_devtype_data. > How about specifying in the changelogs. > Thanks, > > Fabio Estevam > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > spi-devel-general mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/spi-devel-general
------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
