On Fri, 18 May 2012 15:03:33 +0530, Thomas Abraham <[email protected]> wrote: > Add support for device based discovery. > > Signed-off-by: Thomas Abraham <[email protected]> > Acked-by: Jaswinder Singh <[email protected]>
Acked-by: Grant Likely <[email protected]> ... but one nitpick below... > +#ifdef CONFIG_OF > +static const struct of_device_id s3c64xx_spi_dt_match[] = { > + { .compatible = "samsung,exynos4210-spi", > + .data = (void *)EXYNOS4_SPI_PORT_CONFIG, This looks completely backwards. EXYNOS4_SPI_PORT_CONFIG casts a pointer to a kernel_ulong_t, and this casts it right back to a pointer. The cast should be removed entirely from the macro, and the platform_device_id table should have the cast from pointer to ulong. g. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
