On Fri, Jul 06, 2012 at 06:17:25AM -0000, Marek Vasut wrote:
> This is slightly reworked version of the SPI driver.
> Support for DT has been added and it's been converted
> to queued API.
>
> Based on previous attempt by:
> Fabio Estevam <[email protected]>
>
> Signed-off-by: Fabio Estevam <[email protected]>
> Signed-off-by: Marek Vasut <[email protected]>
> Cc: Chris Ball <[email protected]>
> Cc: Detlev Zundel <[email protected]>
> CC: Dong Aisheng <[email protected]>
> Cc: Grant Likely <[email protected]>
> Cc: Linux ARM kernel <[email protected]>
> Cc: Rob Herring <[email protected]>
> CC: Shawn Guo <[email protected]>
> Cc: Stefano Babic <[email protected]>
> Cc: Wolfgang Denk <[email protected]>
>
> ---
> drivers/spi/Kconfig | 7 +
> drivers/spi/Makefile | 1 +
> drivers/spi/spi-mxs.c | 427
> +++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 435 insertions(+)
> create mode 100644 drivers/spi/spi-mxs.c
>
> V2: Fix my patch version management
> Select STMP_DEVICE (thanks Shawn for pointing this out)
>
Hi,
I have one question about this patch.
[ ... ]
> index 0000000..3c0b1ac
> --- /dev/null
> +++ b/drivers/spi/spi-mxs.c
[ ... ]
> +
> +static int __devinit mxs_spi_probe(struct platform_device *pdev)
> +{
[ ... ]
> +out_host_free:
> + clk_disable_unprepare(ssp->clk);
> + spi_master_put(host);
> + kfree(host);
> + return ret;
> +}
> +
> +static int __devexit mxs_spi_remove(struct platform_device *pdev)
> +{
> + struct spi_master *host;
> + struct mxs_spi *spi;
> + struct mxs_ssp *ssp;
> +
> + host = platform_get_drvdata(pdev);
> + spi = spi_master_get_devdata(host);
> + ssp = &spi->ssp;
> +
> + spi_unregister_master(host);
> +
> + platform_set_drvdata(pdev, NULL);
> +
> + clk_disable_unprepare(ssp->clk);
> +
> + spi_master_put(host);
> + kfree(host);
> +
Is the kfree() here and in the probe function really necessary ?
Couple of reasons for asking: No other SPI master driver calls it in the remove
function (unless I missed it), most drivers don't call it in the probe
function error path, and if I call it in the remove function in a SPI master
driver I am working on, and load/unload the module several times in a row, I get
a nasty kernel crash.
Thanks,
Guenter
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
