> -----Original Message----- > From: Joe Perches [mailto:j...@perches.com] > Sent: 2013年1月7日 10:10 > To: Yang, Wenyou > Cc: linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org; Ferre, > Nicolas; plagn...@jcrosoft.com; richard.gen...@gmail.com; Lin, JM; > grant.lik...@secretlab.ca; spi-devel-general@lists.sourceforge.net > Subject: Re: [v3 PATCH 06/12] spi/atmel_spi: add dmaengine support > > On Mon, 2013-01-07 at 09:50 +0800, Wenyou Yang wrote: > > From: Nicolas Ferre <nicolas.fe...@atmel.com> > [] > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > [] > > +static inline bool atmel_spi_use_dma(struct atmel_spi *as, > > + struct spi_transfer *xfer) > > +{ > > + if ((as->use_dma) && (xfer->len >= DMA_MIN_BYTES)) > > + return true; > > + else > > + return false; > > +} > > Same unnecessary form. > > return as->use_dma && xfer->len >= DMA_MIN_BYTES; > > > +static inline bool atmel_spi_use_pdc(struct atmel_spi *as) > > +{ > > + if (as->use_pdc) > > + return true; > > + else > > + return false; > > +} > > Does this function really need to exist at all? > Thanks a lot for your advice.
------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
