On Sat, May 26, 2012 at 1:29 AM, Grant Likely <grant.lik...@secretlab.ca> wrote: > On Mon, 21 May 2012 13:25:23 +0200 (CEST), Guennadi Liakhovetski > <g.liakhovet...@gmx.de> wrote: >> The SPI subsystem core now manages message queues internally. Remove the >> local message queue implementation from the spi-bitbang driver and >> migrate to the common one. >> >> Signed-off-by: Guennadi Liakhovetski <g.liakhovet...@gmx.de> > > Okay, I'm going to be really nitpicky here. The change is fine, but the > diff is too big; particularly for anyone trying to figure out what has > changed if it causes breakage. I wouldn't worry about this as much > for an individual driver, but spi_bitbang is common infrastructure.
Did this ever get around to get fixed? I guess not.... Guennadi, are you going to fix the patch according to Grant's requests or should I try to clean it and resubmit? The problem is that I have no real way of testing this. But if I break something I guess people will notice :-D Yours, Linus Walleij ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
