Hi On Thu, 24 Jan 2013 13:28:58 +0100 Matthias Brugger <[email protected]> wrote:
> This patch fixes some indentation errors. > > Signed-off-by: Matthias Brugger <[email protected]> > --- > drivers/spi/spi-omap2-mcspi.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > ... > @@ -1052,8 +1052,8 @@ static int omap2_mcspi_transfer_one_message(struct > spi_master *master, > } > if (t->speed_hz && t->speed_hz < (OMAP2_MCSPI_MAX_FREQ >> 15)) { > dev_dbg(mcspi->dev, "speed_hz %d below minimum %d Hz\n", > - t->speed_hz, > - OMAP2_MCSPI_MAX_FREQ >> 15); > + t->speed_hz, > + OMAP2_MCSPI_MAX_FREQ >> 15); I have some mixed feelings from these changes and looking at the driver currently. Above change makes the readability a step backward but the driver has already these so in that sense your change makes the style more consistent. I can see three options with this patch: take your patch as it, do nothing or do larger style 'spring cleanup'. I'm personally somewhere take as it or do nothing. If style is not terribly wrong I personally favor smaller style fixes when those lines are changing anyway. In case maintainer takes this you could add: Reviewed-by: Jarkko Nikula <[email protected]> -- Jarkko ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
