On Thu, 27 Dec 2012 10:42:24 +0100, Gabor Juhos <juh...@openwrt.org> wrote: > The driver uses the "as fast as it can" approach > to drive the SCK signal. However this does not > work with certain low speed SPI chips (e.g. the > PCF2123 RTC chip). > > The patch adds per-bit slowdowns in order to be > able to use the driver with such chips as well. > > Signed-off-by: Gabor Juhos <juh...@openwrt.org>
I've applied this, but please take a second look to make sure you're not doing something unintended. The ndelay call will spin until it completes. If the current context is interrupted or scheduled out then it will still spin when it gets back. You may be wasting more time than is necessary. It would be better to check the wall time over a loop iteration. And if the delay required is large, then it should sleep. g. ------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
