>>>>> "MB" == Mark Brown <[email protected]> writes:
Hi,
>> +The property spi-max-frequency is conceptually not needed, as each
>> +child node holds the maximum frequency specific to that
>> +device. However, the SPI core code wants every device in the tree to
>> +specify a maximum frequency. So because the mux is a device to a
>> +parent SPI master, you need to set a maximum frequency. It's best to
>> +set this high, as the driver will take the minimum of this value and
>> +the child's maximum frequency value when doing a transfer to that
>> +child device.
MB> Can't the device just enumerate its children and DTRT?
Agreed.
>> +static const struct of_device_id spi_mux_gpio_of_match[] = {
>> + { .compatible = "spi-mux-gpio", },
>> + {},
>> +};
>> +MODULE_DEVICE_TABLE(of, spi_mux_gpio_of_match);
MB> This looks wrong without a vendor name in it but I'm not sure what we're
MB> supposed to do for generic stuff like this.
It's atleast in line with what we do elsewhere (spi-gpio, i2c-gpio,
i2c-mux-gpio, ..)
--
Bye, Peter Korsgaard
DISCLAIMER:
Unless indicated otherwise, the information contained in this message is
privileged and confidential, and is intended only for the use of the
addressee(s) named above and others who have been specifically authorized to
receive it. If you are not the intended recipient, you are hereby notified that
any dissemination, distribution or copying of this message and/or attachments
is strictly prohibited. The company accepts no liability for any damage caused
by any virus transmitted by this email. Furthermore, the company does not
warrant a proper and complete transmission of this information, nor does it
accept liability for any delays. If you have received this message in error,
please contact the sender and delete the message. Thank you.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
