On Thu, Jul 04, 2013 at 07:36:48PM +0800, yuhang wang wrote: > > I have added the kerneldoc into the patch below to explain the "DUAL" > and "QUAD" modes. > Hope for your suggestions. > > Documentation/spi/spi-dual_quad | 102 +++++++++++++++++++++++++++++++++++++++ > drivers/mtd/devices/m25p80.c | 2 + > drivers/spi/spi.c | 2 + > include/linux/spi/spi.h | 8 +++
I think what Mark meant is to add new fields to the /** comments in include/linux/spi/spi.h, then documentation could be generated (but it seems only outdated copies are online, everyone prefers to look at the code): https://www.kernel.org/doc/htmldocs/device-drivers/ > --- a/drivers/mtd/devices/m25p80.c > +++ b/drivers/mtd/devices/m25p80.c > @@ -354,6 +354,7 @@ static int m25p80_read(struct mtd_info *mtd, > loff_t from, size_t len, > > t[1].rx_buf = buf; > t[1].len = len; > + t[1].bitwidth = flash->spi->rx_bitwidth; > spi_message_add_tail(&t[1], &m); > > mutex_lock(&flash->lock); > @@ -409,6 +410,7 @@ static int m25p80_write(struct mtd_info *mtd, > loff_t to, size_t len, > spi_message_add_tail(&t[0], &m); > > t[1].tx_buf = buf; > + t[1].bitwidth = flash->spi->tx_bitwidth; > spi_message_add_tail(&t[1], &m); > > mutex_lock(&flash->lock); Doesn't m25p80 need to use different commands (OPCODEs) for 2x and 4x speed? It seems this change is incomplete. Thanks, Johannes ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
