On Thu, Oct 24, 2013 at 02:14:59PM +0530, Sourav Poddar wrote: > On Thursday 24 October 2013 01:04 PM, Brian Norris wrote: > >I just submitted my cleanups which (among other things) fixes this bug. > >I believe I CC'd you. Go ahead and review it, and if it works to your > >liking, please just base your work on top of it. I'll apply some or all > >of that series if no one objects. > > > Ok.
I'll push parts the reviewed parts of my patch series now, so you can base off them. (I'm still open to comments on them, though.) > >Do all parts that support quad read also support all the other quad > >opcodes (like quad program)? > > > I have Spansion and Macronix flash with me. > > For spansion, > supported quad commands are: > QOR(0x6b) which is what I am using. > QIOR(0xeb) > DDR QIOR(0xed) > > For macronix, > QOR(0x6b) which is what I am using. > QIOR(0xeb) So it seems there are flash which support quad read but not quad program. So the flag I recommended (M25P80_QUAD) should be made specific to quad read (M25P80_QUAD_READ) I guess, since we may support page program eventually. Brian ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
