On 05/17/10 11:54, Alexander Larsson wrote:
On Wed, 2010-05-12 at 13:32 +0200, Gerd Hoffmann wrote:
-static void qxl_worker_stop(QXLWorker *qxl_worker)
-{
- RedDispatcher *dispatcher = (RedDispatcher *)qxl_worker;
- RedWorkeMessage message = RED_WORKER_MESSAGE_STOP;
+ RedWorkeMessage message = RED_WORKER_MESSAGE_LOADVM_COMMANDS;
+ red_printf("");
Eh?
Prints just the function name. Copyed from somewhere else in the code.
Long-term we probably want some debug logging infrastructure for that.
Printing this stuff is off by default, but with an easy way to enable it
when needed.
@@ -9138,7 +9086,7 @@ static inline void
handle_dev_create_primary_surface(RedWorker *worker)
}
red_create_surface(worker, 0, surface.width, surface.height,
surface.stride, surface.format,
- line_0);
+ line_0, 1);
Maybe add a comment saying why we data_is_valid is needed for primary
surfaces.
Needed only in the save/restore case. Not fully sure it is really ok to
do it unconditionally, although I can't think of a reason why it
shouldn't. Comments?
The alternative would be to do it depending on some bit in surface.flags.
+ switch (ext.cmd.type) {
+ case QXL_CMD_CURSOR:
+ case QXL_CMD_SURFACE:
+ }
Maybe we want a default: here to catch any weird things happening with a
printf?
Yes, good idea. Should never ever trigger in theory, but if it actually
does it should better complain ;)
cheers,
Gerd
_______________________________________________
Spice-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/spice-devel
