On Sun, 2010-08-22 at 14:58 +0300, Yonit Halperin wrote:
> On 08/20/2010 09:54 PM, [email protected] wrote:
> > From: Alexander Larsson<[email protected]>
> >
> > It protects shared data (mspace info) so it needs to be shared.
> > ---
>
> Don't see a problem with making it global, but not sure it is needed.
> Can alloc operations occur on an inactive pdev?
For sure things like DrvDeleteDeviceBitmap() can happen (you said above
that this will be called for all surfaces before disabling the pdev).
And DrvDeleteDeviceBitmap will eventually reach e.g. GetSurfaceCmd which
will cause an AllocMem call.
Also, this points to another issue with the malloc_sem. If ifs
protecting pdev->Res.mspaces, then we really should take it in FreeMem
too, as that calls mspace_free().
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
[email protected] [email protected]
He's an oversexed Republican astronaut possessed of the uncanny powers of an
insect. She's a supernatural winged stripper with someone else's memories.
They fight crime!
_______________________________________________
Spice-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/spice-devel
