----- "Gerd Hoffmann" <[email protected]> wrote: > On 08/24/10 13:57, Alon Levy wrote: > > From 349e6a5bf8804b25c3af6e1f439122a7cc269cc2 Mon Sep 17 00:00:00 > 2001 > > From: Alon Levy<[email protected]> > > Date: Tue, 24 Aug 2010 14:53:03 +0300 > > Subject: [PATCH] vdservice: don't start when no qxl device present > > Point being? > > The display configuration bits are useless without qxl. > > Sending mouse events via vdagent should do fine even with non-qxl > graphics and is less cpu consuming than a usb tablet ... >
There is a general requirement that when a guest is running without spice we "don't interfere". For instance it is run with a regular vga device and rdp is used for vdi. Also, before this patch we just sit there and do nothing because vdagent already has logic such as this patch contains and simply ignores any message it gets if no qxl device exists. I could remove the qxl check in vdagent, or just make it so it only applies to monitor commands / bandwidth reduction measures (which make no sense if qxl isn't used). As this patch stands it doesn't hurt any of the normal behavior and fixes the case of no qxl (which is a regression according to yonit, I think because of code to restart vdagent that maybe wasn't there before). > cheers, > Gerd _______________________________________________ Spice-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/spice-devel
