Hi,

+enum {
+    SPICE_MSG_SMARTCARD_DATA = 1,
+
+    SPICE_MSG_END_SMARTCARD
+};
+
+enum {
+    SPICE_MSGC_SMARTCARD_DATA = 1,
+
+    SPICE_MSGC_END_SMARTCARD
+};

I don't think this is a good idea. This is just a chardev passthrough, right? If so, then we should just make it that. Name it 'chardev' or 'datapipe' or something simliar. Have a additional 'init' message to specify the kind of chardev. Then we can just reuse it when we'll have more simliar users in the future.

Or we could make this a real interface definition where each smartcard message gets its own message type.

Oh, and shouldn't the channel-specific messages better start with '101' like all other channels do?

cheers,
  Gerd
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to