Hi,

On 10/13/2010 09:20 AM, Arnon Gilboa wrote:
Cool.
Did you already test c&p for all these image types in both ways with your 
latest Linux agent?

Yes but I ran into hangs caused by the server failing to unthrottle the vdagent 
port, see the patches
I just posted.

I guess that the data (sent over the wire) is using the standard formats, so 
for win agent/client libpng etc. will do the translation job.
Right

Am I too optimistic?

No libpng should work :)



Hans de Goede wrote:
---
client/x11/platform.cpp | 126 ++++++++++++++++++++++++++---------------------
1 files changed, 70 insertions(+), 56 deletions(-)

diff --git a/client/x11/platform.cpp b/client/x11/platform.cpp
index 9751a30..aed8309 100644
--- a/client/x11/platform.cpp
+++ b/client/x11/platform.cpp

<snip>

@@ -128,15 +139,11 @@ static int32_t clipboard_data_space = 0;
static Atom clipboard_request_target = None;
static selection_request *next_selection_request = NULL;
static uint32_t clipboard_type_count = 0;
-/* TODO Add support for more types here */
-/* Warning the size of these 2 needs to be increased each time we add
- support for a new type!! */
-static uint32_t clipboard_agent_types[1];
-static Atom clipboard_x11_targets[1];
+static uint32_t clipboard_agent_types[256];
+static Atom clipboard_x11_targets[256];
256 is one of my favorite numbers ;)

hehe

<snip>

+ LOG_WARN("sendtargets: too much targets");
"too many" ;)

Fixed (everywhere)

<snip>

Thanks & Regards,

Hans

_______________________________________________
Spice-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to