Hi all, Ack to series.
Regards, Hans On 01/25/2011 04:33 PM, Alon Levy wrote:
This is the downfall of me running rawhide and having been upgraded to gcc 4.6.0 recently. But it's all good, since it's really things we want to fix. Some of the comments are a little more verbose then required, (talking about the third patch, remove unused error val). The only tricky bit is in the demarshaller/marshaller, since the downside of having code generated is that you sometimes need to fix the generator.. I tried doing a really swanky track-used-variables before I did this simple fix, and discovered some hidden dragons (the subwriter's are not correctly scoped), but I think my final solution is good - higher level and more specific. Also the first patch could be split if someone insists. I'm suggesting these for 0.8 too since they are basically bug fixes. Alon Levy (9): client/server: warning fixes (gcc 4.6.0) common/canvas_base.c: remove unused variables common/sw_canvas: remove unused error val client/display_channel: gcc 4.6.0 unused fixes client/glz_decoder.cpp: gcc 4.6.0 unused fixes client/cegui: cegui 0.6.0 gcc 4.6.0 related fix client: gcc 4.6.0: two more unused variable fixes codegen: avoid creating out if not used (fix gcc 4.6.0 warning) demarshaller/marshaller fix gcc 4.6.0 client/display_channel.cpp | 18 ++++++++++++------ client/glz_decoder.cpp | 5 ----- client/gui/resource_provider.h | 3 +++ client/gui/softrenderer.h | 2 ++ client/gui/softtexture.h | 3 +++ client/hot_keys.cpp | 2 -- client/red_client.cpp | 1 - client/x11/platform.cpp | 7 +++++-- common/canvas_base.c | 12 ------------ common/sw_canvas.c | 3 +-- python_modules/demarshal.py | 30 +++++++++++++++++++++--------- python_modules/marshal.py | 8 +++++--- server/jpeg_encoder.c | 3 +-- server/red_parse_qxl.c | 3 +-- server/red_worker.c | 14 +------------- server/reds.c | 5 +++-- 16 files changed, 58 insertions(+), 61 deletions(-)
_______________________________________________ Spice-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/spice-devel
