On Wed, Feb 02, 2011 at 07:53:35PM +0100, Marc-André Lureau wrote:
> ack
>
> (I would prefer return_if_fail(channel != NULL) instead here)
>
> On Wed, Jan 19, 2011 at 7:08 PM, Alon Levy <[email protected]> wrote:
> > ---
> > server/red_channel.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/server/red_channel.c b/server/red_channel.c
> > index 0eba73c..b621be9 100644
> > --- a/server/red_channel.c
> > +++ b/server/red_channel.c
> > @@ -601,10 +601,11 @@ int red_channel_is_connected(RedChannel *channel)
> > void red_channel_pipe_clear(RedChannel *channel)
> > {
> > PipeItem *item;
> > +
> > + ASSERT(channel);
> > if (channel->send_data.item) {
> > channel->release_item(channel, channel->send_data.item, TRUE);
> > }
> > -
>
> I liked that extra line too ;)
No argueing in matters of taste (*)
(*) unless there is a CODING_STYLE :>
>
> > while ((item = (PipeItem *)ring_get_head(&channel->pipe))) {
> > ring_remove(&item->link);
> > channel->release_item(channel, item, FALSE);
> > --
> > 1.7.3.4
> >
> > _______________________________________________
> > Spice-devel mailing list
> > [email protected]
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> >
>
>
>
> --
> Marc-André Lureau
_______________________________________________
Spice-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/spice-devel
