Hi,
1-8 look good, ack,
9 also looks good, but I've some small comments, see my
separate reply.
Regards,
Hans
On 02/09/2011 11:20 AM, Alon Levy wrote:
The protocol has been updated through the review process on qemu-devel.
These patches address the changes:
* big endianess byte order
* VSC_Error response for ReaderAdd, ReaderRemove, ATR and CardRemove.
The most complicated patch is the last, touching the client. It adds a
synchronized event queue for the four Card/Reader Remove/Add messages, so we
only have one outstanding (waiting for VSC_Error response) message in the
client.
Alon Levy (9):
server/smartcard: s/reader_id_t/uint32_t/ (libcacard changed)
server/smartcard: libcacard removed ReaderAddResponse
client/smartcard: s/reader_id_t/uint32_t/ (libcacard changed)
server/smartcard: libcacard uses network byte order, so we must too
server/smartcard: print instead of assert on bad reader_id in
smartcard_char_device_on_message_from_device
server/smartcard: ignore VSC_Init from client
client/smartcard: ignore VSC_Init
server/smartcard: don't push our own error on reader add
client/smartcard: libcacard dropped ReaderAddResponse
client/smartcard_channel.cpp | 99 ++++++++++++++++++++++++++++++++----------
client/smartcard_channel.h | 21 ++++++---
server/smartcard.c | 92 +++++++++++++++------------------------
3 files changed, 127 insertions(+), 85 deletions(-)
_______________________________________________
Spice-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/spice-devel
