On Mon, Mar 21, 2011 at 04:34:34PM +0100, Christophe Fergeau wrote: > On Mon, Mar 21, 2011 at 05:24:54PM +0200, Alon Levy wrote: > > > > Well, this is test code, I would want to get back to this eventually, so > > could you turn this into a non static (and then the compiler won't complain) > > instead? if that doesn't work even #if 0 is better. (again, test code). > > > > Adding 'static void init_cursor() __attribute__((unused));' before the > function definition avoid the warning, but I don't know how (in)dependant > from GCC the code base should be? If that's too specific, I'll go with the > #if 0. I'm not a big fan of making this function non-static in case someone > uses this code as a base for something that is not a test and forget to > readd the missing 'static' err, it's under the directory "test", how much warning do you want to give people? ;) I guess #if 0 is better though.
> > Thanks for the review, > > Christophe > _______________________________________________ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/spice-devel _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel