Hi,

On 04/02/2011 11:24 AM, Alon Levy wrote:
On Fri, Apr 01, 2011 at 05:13:09PM +0200, Hans de Goede wrote:
The check this patch removes causes us to not set vdagent to NULL, nor
update the mouse mode when the guest agent disconnects when no client is
attached. Which leads to a non working mouse, and on agent reconnect a
"spice_server_char_device_add_interface: vdagent already attached" message
instead of a successful re-add of the agent interface .

Well, that's my patch. So the ASSERT gets turned to an if and then dropped.
I like you explanation better then mine. At least now I know who to blame for
my non working agent - me!

Does that mean your "windows agent woes" are fixed with this patch ?

ACK.

Thanks, any chance you could also review:

[Spice-devel] [PATCH 0.8 5/9] server: filter all data from client   Hans de 
Goede
[Spice-devel] [PATCH 0.8 6/9] server: add discard all option to agent message 
filter   Hans de Goede
[Spice-devel] [PATCH 0.8 7/9] server: hookup agent-msg-filter discard-all 
functionality   Hans de Goede
[Spice-devel] [PATCH 0.8 8/9] server: ignore SPICE_MSGC_MAIN_AGENT_START 
messages when there is no agent   Hans de Goede

?

Regards,

Hans
_______________________________________________
Spice-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to